Skip to content

feat(cli): add read-only /mcp status command - #876

Open
fortissolucoescontato-bit wants to merge 3 commits into
CodebuffAI:mainfrom
fortissolucoescontato-bit:feat/mcp-cli-status
Open

feat(cli): add read-only /mcp status command#876
fortissolucoescontato-bit wants to merge 3 commits into
CodebuffAI:mainfrom
fortissolucoescontato-bit:feat/mcp-cli-status

Conversation

@fortissolucoescontato-bit

@fortissolucoescontato-bit fortissolucoescontato-bit commented Jul 17, 2026

Copy link
Copy Markdown

Summary

Adds a read-only /mcp command for inspecting configured MCP servers and the current runtime connection state.

The implementation reuses the existing MCP configuration loader and runtime state. It does not introduce a second MCP client, modify MCP configuration files, or initiate connections when rendering the status.

Commands

  • /mcp
  • /mcp list

Unknown subcommands display inline usage information.

Output

The command displays:

  • configured server name;
  • connection status;
  • transport;
  • discovered tool count;
  • sanitized connection errors;
  • sanitized configuration path.

When no servers are configured, it provides a short example using the existing .agents/mcp.json format.

Security

  • Read-only command;
  • does not modify .agents/mcp.json;
  • does not initiate MCP connections;
  • redacts tokens, API keys, credentials and authorization headers;
  • sanitizes credentials embedded in URLs;
  • truncates oversized errors;
  • replaces the user home directory with ~;
  • covers Linux, macOS and Windows path formats.

Implementation

  • Adds a public read-only MCP runtime status API in common;
  • adds the /mcp command handler and formatter in cli;
  • registers /mcp in the command registry and slash-command autocomplete;
  • documents /mcp in the public README.

Verification

  • MCP command tests: 51 passing;
  • related CLI tests: 217 passing (13 files);
  • parser integration tests: PASS;
  • lifecycle tests: PASS;
  • SDK build: PASS;
  • Freebuff build: PASS;
  • local CI (bun run ci): PASS;
  • typecheck: no new errors vs upstream/main;
  • git diff --check: PASS.

Scope

This PR intentionally does not implement:

  • /mcp add;
  • /mcp remove;
  • /mcp reload;
  • /mcp inspect.

Those can be considered separately after the read-only status command is reviewed.

Fortissoluções added 3 commits July 17, 2026 13:57
Fortissoluções
feat(cli): add read-only /mcp status command
28d8ba2
Fortissoluções
feat(cli): add sanitization, truncation, and error tracking for /mcp
6520c1c
Fortissoluções
feat(cli): add /mcp list parser, /mcp unknown help, cross-platform pa…
4da1189 
…th sanitization, and expanded credential redaction

- Switch /mcp from defineCommand to defineCommandWithArgs for subcommand parsing
- Add /mcp unknown subcommand handling that shows inline help with usage
- Add /mcp list to help banner (Tips section)
- Implement proper cross-platform sanitizePath replacing home dir with ~
- Add URL credentials, Basic auth, github_pat_, access_token, refresh_token,
  client_secret, passwd, and Authorization header sanitization patterns
- Remove unused hashMcpConfig and getConnectedMCPClientKeys exports
- Add parser integration tests, path sanitization tests, lifecycle tests,
  and expanded sanitization pattern tests
- Improve JSDoc for McpClientConnectionInfo and getMCPClientConnectionInfo
@fortissolucoescontato-bit fortissolucoescontato-bit mentioned this pull request Jul 17, 2026
Open
@micahcooley micahcooley mentioned this pull request Aug 6, 2026
Open
@codebuff-team

codebuff-team commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Nice feature — a read-only /mcp status command that reuses existing config loading and connection state instead of spinning up a second MCP client is exactly the right shape for this. The sanitizeErrorForDisplay/truncateError additions in common/src/mcp/client.ts are a genuinely useful addition beyond just this command, and the test coverage in mcp-command.test.ts is thorough (redaction patterns, truncation boundaries, cross-platform path sanitization).

A few things worth fixing before porting:

  1. cli/src/components/help-banner.tsx — the diff adds a stray leading space to the existing "Use @ to reference..." line (- Use @ → + Use @, one extra space) and the new /mcp line has the same extra-space typo. Looks like an accidental find/replace artifact; please fix the indentation so it matches the surrounding <text> blocks exactly.

  2. connectionErrors and resolvedToolCounts in common/src/mcp/client.ts are module-level maps keyed by config hash that are never cleared on success/reconnect (aside from the connected gate hiding stale errors). Bounded by number of distinct configs so not urgent, but worth a comment or TODO acknowledging the lifecycle.

  3. The SENSITIVE_PATTERNS list is broad (e.g. token=, secret=) and could over-redact legitimate non-secret strings in server stderr — acceptable for a security-conservative default, but worth flagging in the PR description that false positives are expected.

None of these block review — the core design (read-only, no side effects, sanitized output) is sound and matches what a maintainer would want to see before adding write commands (/mcp add, etc.) later.

@codebuff-team codebuff-team added bot:triaged Classified by the community triage bot pr:port-candidate Worth porting into the private source tree labels Aug 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bot:triaged Classified by the community triage bot pr:port-candidate Worth porting into the private source tree

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fortissolucoescontato-bit @codebuff-team